(proof-systems) Native Prover with Napi - Proof
#3368
Conversation
…-conversion Napi conversions of proof-related types
(Native Prover) Oracles
(proof-systems) Native Prover with Napi - POC - Verifier Index
Shigoto-dev19
left a comment
Shigoto-dev19
left a comment
There was a problem hiding this comment.
Lgtm! Just left small comments / questions
There was a problem hiding this comment.
More changes to come from the child PR #3381.
There was a problem hiding this comment.
More changes to come from the child PR #3381.
| self.sorted = s | ||
| } | ||
|
|
||
| #[napi(setter, js_name="set_aggreg")] |
There was a problem hiding this comment.
| #[napi(setter, js_name="set_aggreg")] | |
| #[napi(setter, js_name = "set_aggreg")] |
Just for consistency, sometimes we do leave white spaces like in here and sometimes not
There was a problem hiding this comment.
True, I will have to create a big PR to native/napi to pass the lint checks
| } | ||
|
|
||
| #[napi(js_name = [<"caml_" $name:snake "_srs_create">])] | ||
| pub fn [<caml_ $name:snake _srs_create>](depth: i32) -> External<[<Napi $name:camel Srs>]> { |
There was a problem hiding this comment.
Did using External here cause any errors?
There was a problem hiding this comment.
I also see that you used to_bytes_external but isn't it possible to work around that by consistently using External<[<Napi $name:camel Srs>]> 🤔
There was a problem hiding this comment.
It's fine to use externals as inputs but the first time the SRS is created I needed to pass the whole thing. Will give it a try again once more changes are in, but that was the case back then at least.
There was a problem hiding this comment.
I see! Thanks for the clarification :)
(`proof-systems`) Native Prover with Napi - Verifier Index
o1js side: o1-labs/o1js#2632
mina side: MinaProtocol/mina#18109
Closes o1-labs/o1js#2493 and o1-labs/o1js#2487